-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the last_ping
key again
#255
Merged
eliasyishak
merged 7 commits into
dart-lang:main
from
eliasyishak:252-type-error-on-session-json
Mar 14, 2024
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
11b72c3
Rewrite the `last_ping` key again
eliasyishak 3b9a49a
Apply test fix from #247
eliasyishak 3848b52
Use timestamp instead of null
eliasyishak ed797f5
Format fix
eliasyishak 7ad01f5
Update version
eliasyishak 1a35ba1
Code review comments
eliasyishak 7e68e63
Lingering comment
eliasyishak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -118,6 +118,21 @@ class Session { | |
description: err.osError?.toString(), | ||
)); | ||
|
||
// Fallback to setting the session id as the current time | ||
_sessionId = now.millisecondsSinceEpoch; | ||
// ignore: avoid_catching_errors | ||
} on TypeError catch (err) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's not catch TypeError, and instead be disciplined about never deleting fields from this JSON file. |
||
final now = clock.now(); | ||
Initializer.createSessionFile( | ||
sessionFile: sessionFile, | ||
sessionIdOverride: now, | ||
); | ||
|
||
_errorHandler.log(Event.analyticsException( | ||
workflow: 'Session._refreshSessionData', | ||
error: err.runtimeType.toString(), | ||
)); | ||
|
||
// Fallback to setting the session id as the current time | ||
_sessionId = now.millisecondsSinceEpoch; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation for why I think this is necessary: