expand the sdk constraint; rev version #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Aug 2, 2017
| @@ -11,7 +11,7 @@ | |||
| /// That means that using the [TypedDataView.buffer] getter is not guaranteed | |||
| /// to return the same result each time it is used, and that the buffer may | |||
| /// be larger than what the list is using. | |||
| library dart.pkg.typed_data.typed_buffers; | |||
There was a problem hiding this comment.
I think this should be typed_data.typed_buffers.
If it's not the name of the package, it should be prefixed with it.
|
updated, ptal |
kevmoo
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lrhn @kevmoo @nex3