Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable and fix package:pedantic lints #135

Merged
merged 2 commits into from Jan 13, 2020
Merged

Enable and fix package:pedantic lints #135

merged 2 commits into from Jan 13, 2020

Conversation

natebosch
Copy link
Member

  • always_declare_return_types
  • omit_local_variable_types
  • prefer_collection_literals
  • prefer_if_null_operators
  • unawaited_futures

Bump min SDK to 2.2.0 to support Set literals.

@natebosch
Enable and fix package:pedantic lints
5c6160a 
- always_declare_return_types
- omit_local_variable_types
- prefer_collection_literals
- prefer_if_null_operators
- unawaited_futures

Bump min SDK to 2.2.0 to support Set literals.
@googlebot googlebot added the cla: yes Google CLA signed label Dec 9, 2019
@natebosch natebosch requested a review from grouma December 9, 2019 21:39
@devoncarew
Copy link
Member

Thanks for the PRs @natebosch; @grouma, @natebosch, I'd like the opportunity to review these before they get merged.

@natebosch natebosch requested review from devoncarew and removed request for grouma December 9, 2019 21:50
@natebosch
Copy link
Member Author

@devoncarew - any update?

@kevmoo
Copy link
Member

kevmoo commented Jan 13, 2020

LGTM! @devoncarew ?

devoncarew
devoncarew approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the recent design doc from mit, pedantic is too pedantic. I'll update this package to use whatever LCD rule set we come up with once it exists.

analysis_options.yaml Outdated
@@ -1,3 +1,4 @@
include: package:pedantic/analysis_options.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should peg this to a specific version so that changes to the pedantic package won't break the CI here.

@natebosch
Copy link
Member Author

pedantic is too pedantic

FWIW omit_local_variable_types is the only lint that showed up here that might be excluded from other attempts at a standardized lint set. The others are very likely to be included.

@natebosch natebosch merged commit c2051dd into master Jan 13, 2020
@natebosch natebosch deleted the package-pedantic-lints branch January 13, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@natebosch @devoncarew @kevmoo @googlebot