This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Enable and fix package:pedantic lints #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always_declare_return_types - omit_local_variable_types - prefer_collection_literals - prefer_if_null_operators - unawaited_futures Bump min SDK to 2.2.0 to support Set literals.
|
Thanks for the PRs @natebosch; @grouma, @natebosch, I'd like the opportunity to review these before they get merged. |
|
@devoncarew - any update? |
|
LGTM! @devoncarew ? |
kevmoo
approved these changes
Jan 13, 2020
devoncarew
approved these changes
Jan 13, 2020
analysis_options.yaml
Outdated
| @@ -1,3 +1,4 @@ | |||
| include: package:pedantic/analysis_options.yaml | |||
There was a problem hiding this comment.
We should peg this to a specific version so that changes to the pedantic package won't break the CI here.
FWIW |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump min SDK to 2.2.0 to support Set literals.