Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

postEncode expect all values to be strings #17

Merged
merged 3 commits into from
Dec 17, 2014
Merged

postEncode expect all values to be strings #17

merged 3 commits into from
Dec 17, 2014

Conversation

Fox32
Copy link
Contributor

@Fox32 Fox32 commented Dec 17, 2014

The sendTiming parameter time is of type int, but internally type string is required. Im using

      _analytics.sendTiming('LoadTime', stopwatch.elapsedMilliseconds);

but it crashes as postEncode in usage_impl.dart requires all map values to be strings, but 'utt' is an integer. Therefore time should be converted to a string first.

Therefore time should be converted to a string first.
@Fox32
Copy link
Contributor Author

Fox32 commented Dec 17, 2014

I think in the end that would also mean that setSessionValue and sendEvent should do that, too?

@devoncarew
Copy link
Contributor

Awesome, good catch! lgtm. Can you add yourself to the end of the AUTHORS file as well? It should be a

First Last <email>

format. Thanks!

@Fox32
Copy link
Contributor Author

Fox32 commented Dec 17, 2014

Done

@devoncarew
Copy link
Contributor

Great, thanks!

devoncarew added a commit that referenced this pull request Dec 17, 2014
postEncode expect all values to be strings
@devoncarew devoncarew merged commit 12612e5 into dart-archive:master Dec 17, 2014
@Fox32 Fox32 deleted the patch-1 branch December 17, 2014 19:12
@devoncarew
Copy link
Contributor

(pushed a new version to capture this fix)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants