This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Add flags to setup.dart required to get Android build working #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need a changelog entry? Or a readme entry? Other than it looks okay and CI is passing...I'm not an expert here. CC @mit-mit |
kevmoo
approved these changes
Oct 13, 2021
|
Added a changelog entry. I don't think it needs a readme entry, because users shouldn't be messing with these options. The flutter plugin will automatically use those options to configure the build for the target device. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a wasm plugin for Flutter. The main thing that the plugin will have to do is run the setup script to build the runtime for the target platform. So I added a bunch of flags to setup.dart so that the build can be configured. With this, I now have a working demo app running package:wasm on Android.
Part of #40