Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAC_FF_META to KeyCode constants #264

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

arnaud-secondlayer
Copy link
Contributor

This PR adds the missing declaration of MAC_FF_META key code value to the KeyCode constants.
MAC_Fleur_META (value is 224) is fired by Firefox on macOS when pressing the META key, instead of the common META key value (91).

I kept the same comment as Closure's Keycode enumeration.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kevmoo kevmoo requested a review from srujzs June 27, 2024 14:44
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it matches the dart:html definition, so LGTM. For formatting, I'd prefer the comment go above the ignore. Thanks!

@kevmoo kevmoo merged commit 82b94c2 into dart-lang:main Jun 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants