Unused fields and dartdoc references #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
reviewed
Oct 20, 2017
| /// use the WebSocket protocol over a pre-existing channel. | ||
| /// This is implemented by classes that use `dart:io` and `dart:html`. The | ||
| /// [new WebSocketChannel] constructor can also be used on any platform to | ||
| /// connect to use the WebSocket protocol over a pre-existing channel. |
There was a problem hiding this comment.
Does dartdoc not work with multi-line references? Is there a bug for that?
There was a problem hiding this comment.
I just checked the generated docs, and it looks like this link is working fine, so this change isn't necessary.
nex3
reviewed
Oct 20, 2017
| const String _clientNoContextTakeover = "client_no_context_takeover"; | ||
| const String _serverNoContextTakeover = "server_no_context_takeover"; | ||
| const String _clientMaxWindowBits = "client_max_window_bits"; | ||
| const String _serverMaxWindowBits = "server_max_window_bits"; |
There was a problem hiding this comment.
This is copied from the SDK. I don't want to modify it any more than absolutely necessary to get it to work here, because every modification makes merging in new versions harder.
|
@kevmoo Are you planning on iterating on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.