-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseUrl has the wrong value because app path has "/test/" in it #1965
Comments
I didn't think flutter was still using |
Hmmm.. I'm not sure. We do generate But when the file gets served by the web server, I see more content appended to the file. That extra content is exactly the same as this I don't see a direct dependency on Note: This only happens in debug mode (using DDC). cc @jonahwilliams who may have some extra context. |
We don't use build_web_compilers, but some of the flutter tool code was taken from bwc initially |
Ok, so probably the fix needs to be in the flutter tool code which was originally taken from bwc. I am not really sure what the right fix is here, or if that logic is even relevant for flutter web. |
I don't think I am going to bother fixing it in bwc unless somebody files an issue as I think this is probably pretty uncommon. |
Thanks @jakemac53 and @jonahwilliams. I transferred the issue to the webdev repo (where dwds lives). |
@mdebbar thanks for filing the issue! I'll take a look. |
Can confirm this is still happening with:
|
Here is the relevant code that was copied to dwds. Here is the code in dwds:
webdev/dwds/lib/src/loaders/require.dart
Lines 36 to 46 in 3ad544e
We got a report from a user seeing this issue (and I was able to reproduce it, too): flutter/flutter#116360 (comment)
Basically, their app has a path "/sample_item/test/", it trips the generated bootstrap code into thinking that it's in test mode, and it calculates the wrong
baseUrl
.The text was updated successfully, but these errors were encountered: