Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate WebDev and build_runner daemon #101

Merged
merged 4 commits into from
Jan 28, 2019
Merged

Integrate WebDev and build_runner daemon #101

merged 4 commits into from
Jan 28, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Jan 25, 2019

  • Create new command serve2 which will eventually replace serve
  • The new command will:
    • be hidden for the time being
    • connect to the build daemon
    • create a proxy server for each requested build target
      • this server forward requests to the daemon asset server
      • in the future this server will have hooks for hot reload / hot restart
  • Add and E2E integration test
    • This test is expected to fail until package:build_runner version 1.2.1 is released

Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is logic here (somewhere) to constrain the versions of build_runner that are supported. Guessing that needs to get updated too, right?

@grouma
Copy link
Member Author

grouma commented Jan 25, 2019

@kevmoo
Copy link
Member

kevmoo commented Jan 25, 2019 via email

webdev/lib/src/command/serve2_command.dart Outdated Show resolved Hide resolved
webdev/lib/src/command/serve2_command.dart Show resolved Hide resolved
webdev/lib/src/serve/daemon_client.dart Outdated Show resolved Hide resolved
webdev/lib/src/serve/handlers/asset_handler.dart Outdated Show resolved Hide resolved
@grouma grouma merged commit 44d4284 into master Jan 28, 2019
@grouma grouma deleted the daemon-integration branch January 28, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants