Show a warning in the Dart Debug Extension when a user tries to debug a sharded Dart app #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Thanks Elliott!
To make sure we track the change in our published versions correctly, could you please:
- add a test - maybe
dwds/test/debug_extension_test.dartcan help? - add a CHANGELOG.md message
- could you please update the version in pubspec.yaml to the new dev version (ie 11.5.1-dev)
- run
dart run build_runner buildin dwds directory (using the latest dart, I normally use the latest dev but stable is ok too)
|
Everything should be updated now, thanks! |
annagrin
suggested changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we detect that a Dart application is sharded, the Dart Debug Extension turns red. Clicking on it will open the following alert:
