Cleanup record types display #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 31, 2023 10:21
annagrin
commented
Apr 4, 2023
annagrin
requested review from
elliette and
nshahan
and removed request for
elliette
|
This looks like only test files are included right now. From the description it sounds like there should be some implementation. Is that expected? |
elliette
reviewed
Apr 4, 2023
elliette
reviewed
Apr 4, 2023
Implementation is included as well (see |
elliette
reviewed
Apr 4, 2023
added 2 commits
April 4, 2023 16:58
nshahan
reviewed
Apr 5, 2023
elliette
reviewed
Apr 21, 2023
| @@ -64,7 +64,17 @@ class TestInspector { | |||
|
|
|||
| expect(result, isA<Instance>()); | |||
| final instance = result as Instance; | |||
| expect(instance.kind, instanceKind); | |||
|
|
|||
| // TODO(annagrin): we sometimes get mismatching reference | |||
There was a problem hiding this comment.
Open a bug with details to track?
nshahan
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
RecordTypeinstances:InstanceKind.kRecordType.Closes: #2065