Allow client to specify how to find the package config #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
changed the title
annagrin
reviewed
Aug 18, 2023
dwds/lib/src/utilities/globals.dart
Outdated
| void setPackageConfigPath(path) => _packageConfigPath = path; | ||
|
|
||
| /// The default package config path, if none is provided by the load strategy. | ||
| String get _defaultPackageConfigPath => p.join( |
There was a problem hiding this comment.
Can we add tests for a scenario where the package config is not located in a usual place?
There was a problem hiding this comment.
Done, added a load_strategy_test for this
dwds/test/fixtures/fakes.dart
Outdated
| @@ -368,7 +371,7 @@ class FakeStrategy implements LoadStrategy { | |||
| MetadataProvider(entrypoint, FakeAssetReader()); | |||
|
|
|||
| @override | |||
| void trackEntrypoint(String entrypoint) {} | |||
| Future<void> trackEntrypoint(String entrypoint) => Future.value(null); | |||
There was a problem hiding this comment.
Can this be Future<void> trackEntrypoint(String entrypoint) async {} instead?
There was a problem hiding this comment.
Removed this because the FakeStrategy now extends instead of implements the LoadStrategy
dwds/lib/src/utilities/globals.dart
Outdated
| import 'package:path/path.dart' as p; | ||
|
|
||
| /// The path to the package config. | ||
| String get packageConfigPath => _packageConfigPath ?? _defaultPackageConfigPath; |
There was a problem hiding this comment.
Do we need a special global for this? Can it be just a part of the global strategy, to minimize the number of globals?
There was a problem hiding this comment.
Sure, moved to global strategy instead
helin24
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2198
The package config is not located at
.dart_tool/package_config.jsonfor google3 apps, therefore we need to provide a way for the code runner to specify where to look for it.CC @helin24