Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cider expects messages from a Chrome extension to be a JS object, not a string #2249

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Cider expects messages from a Chrome extension to be a JS object, not a string #2249

merged 3 commits into from
Oct 12, 2023

Conversation

elliette
Copy link
Contributor

Previously we were sending a JSON string to Cider. Cider actually expects the message to be a JS object, so now we are passing a JS object that looks like:

{
key: 'CIDER_DART',
json: [[the original json string]]
}

Work towards #2198

@elliette elliette requested a review from helin24 October 11, 2023 22:46
@elliette elliette merged commit 63c7e72 into dart-lang:master Oct 12, 2023
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helin24 helin24 helin24 approved these changes

Assignees
No one assigned
Labels
changelog-not-required dart-debug-extension package:dwds run-dcm-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elliette @helin24