Fix test cases failing with latest Dart SDK #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elliette
commented
Dec 19, 2023
•
elliette
commented
- fixes a new static analysis error
- updates the tests now that the new DDC type system isn't guarded behind the canary features flag
- skips the failing FrontendServerClient tests (I'm guessing this is a real issue but haven't had time to investigate, opened Frontend server client tests are failing with most recent Dart SDK #2315 - FYI @jakemac53 @derekxu16, this is failing on both the dev and main branches)
elliette
changed the title
elliette
changed the title
Markzipan
reviewed
Dec 21, 2023
dwds/test/inspector_test.dart
Outdated
| @@ -160,6 +161,10 @@ void main() { | |||
| final names = | |||
| properties.map((p) => p.name).where((x) => x != '__proto__').toList(); | |||
| final expected = [ | |||
| if (dartSdkIsAtLeast( | |||
| '3.3.0-242.0.dev', | |||
There was a problem hiding this comment.
If this is the known cutoff point, could we store it in a const in a shared lib?
| if (dartSdkIsAtLeast( | ||
| '3.3.0-242.0.dev', | ||
| )) | ||
| 'T', |
There was a problem hiding this comment.
I think this is fine to do to get things working, but we likely don't want T to be exposed here - as it's not meant to be user-visible.
There was a problem hiding this comment.
Added a TODO and opened an issue
CoderDake
approved these changes
Dec 27, 2023
elliette
added a commit
to elliette/webdev
that referenced
this pull request
Dec 27, 2023
elliette
added a commit
to elliette/webdev
that referenced
this pull request
Dec 27, 2023
This reverts commit 2ef79f1.
elliette
added a commit
to elliette/webdev
that referenced
this pull request
Dec 28, 2023
This reverts commit 2563295.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.