Fix reading pause_isolates_on_start value from the DWDS
#2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markzipan
reviewed
Mar 26, 2024
| @@ -121,6 +121,9 @@ class DevHandler { | |||
| _servicesByAppId.clear(); | |||
| }(); | |||
|
|
|||
| bool shouldPauseIsolatesOnStart(String appId) => | |||
| _servicesByAppId[appId]?.chromeProxyService.pauseIsolatesOnStart ?? false; | |||
There was a problem hiding this comment.
I'm not familiar with this part - when do we expect _servicesByAppId[appId] to be null?
There was a problem hiding this comment.
_servicesByAppId[appId] is null when the debug session has been closed (which is exactly what we want, because that means shouldPauseIsolatesOnStart will return false and the code runner which calls this won't wait for a resume event
Markzipan
approved these changes
Mar 26, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2373
The
debugConnectionmethod (in which we were listening to thepauseIsolatesOnStartStream) is actually only called from test code. 🤦♀️This allows us to actually access the
pause_isolates_on_startflag value in theDwdsclass.Work towards flutter/devtools#7231