implementing life cycle rpc method like getmanifest to be able to run the plugin #26

vincenzopalazzo · 2022-06-15T23:14:34Z

This should unlock you! this time for real!

Fixes #19

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

packages/cln_plugin/.gitignore

packages/cln_plugin/lib/src/cln_plugin_base.dart

swaptr · 2022-06-16T15:25:42Z

packages/cln_plugin/lib/src/cln_plugin_base.dart

+        .toList();
+    response["subscriptions"] = plugin.subscriptions;
+    response["hooks"] = plugin.hooks.toList();
+    response["notifications"] = [];


Why is this [] and not plugin.notifications?

Because the notification it is not a list of string but a list of object! So we need to find a way of how to do that!

So like a list of notification objects, similar to JRPCLightning?

the two concept are analogous, are implementing the same stuff

swaptr · 2022-06-16T15:30:06Z

packages/cln_plugin/lib/src/cln_plugin_base.dart

@@ -46,12 +49,12 @@ class Plugin implements CLNPlugin {
      required String def,
      required String description,
      required bool deprecated}) {
-    options = Option(
+    options.add(Option(


Here we are maintaining a List<Option> so shouldn't we just add the new option onto the list?

the option are the value that the user can put with --some=hello, so this is a list of option and not a single one!

We need to add inside the list the options, and I was unable to understand way you was doing options = Option I assumed it was a mistake

So this is correct?

Why should be wrong? this code the code that I removed is also wrong! you are casting a option into a List

packages/cln_plugin/lib/src/cln_plugin_base.dart

vincenzopalazzo · 2022-06-15T23:26:39Z

packages/cln_plugin/lib/src/cln_plugin_base.dart

+        .toList();
+    response["subscriptions"] = plugin.subscriptions;
+    response["hooks"] = plugin.hooks.toList();
+    response["notifications"] = [];


Suggested change

response["notifications"] = [];

response["notifications"] = [];

We need to check what type of object it is required by cln here @swaptr

vincenzopalazzo · 2022-06-15T23:27:29Z

packages/cln_plugin/lib/src/cln_plugin_base.dart

+    response["options"] = plugin.options.map((opt) => opt.toMap()).toList();
+    response["rpcmethods"] = plugin.rpcMethods.values
+        .where((rpc) => rpc.name != "init" && rpc.name != "getmanifest")
+        .map((rpc) => rpc.toMap())
+        .toList();
+    response["subscriptions"] = plugin.subscriptions;
+    response["hooks"] = plugin.hooks.toList();
+    response["notifications"] = [];


We need to check this with attention with the core lightning docs, maybe we can write some units tests @swaptr

packages/cln_plugin/lib/src/cln_plugin_base.dart

vincenzopalazzo · 2022-06-16T15:26:56Z

packages/cln_plugin/lib/src/cln_plugin_base.dart

@@ -138,7 +144,7 @@ class Plugin implements CLNPlugin {
    var result = HashMap<String, Object>();
    result["level"] = level;
    result["message"] = message;
-    stdout.write(jsonDecode(Response(result: result).toJson()));
+    stdout.write(Response(result: result).toJson());


Sure that this works?

The error on IDE disappears but when I try to log the messageSocket in start() method, this is returned 2022-06-16T16:00:01.315Z UNUSUAL plugin-cln_plugin_example.exe: Killing plugin: Malformed JSON-RPC notification missing "method" or "params": {"jsonrpc":"2.0","result":{"level":"debug","message":"Instance of 'Request'"}}

maybe you need to put the also the id inside the constructor?

Somethings like Response(id: 40, result: result).toJson()

vincenzopalazzo · 2022-06-16T15:27:53Z

packages/cln_plugin/lib/src/cln_plugin_base.dart

+        .toList();
+    response["subscriptions"] = plugin.subscriptions;
+    response["hooks"] = plugin.hooks.toList();
+    response["notifications"] = [];


Because the notification it is not a list of string but a list of object! So we need to find a way of how to do that!

packages/cln_plugin/lib/src/cln_plugin_base.dart

Co-authored-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

swaptr and others added 5 commits June 16, 2022 04:32

plugin: implement rpc request parsing and plugin init.

0d8cdad

plugin: implement rpc request parsing and plugin init.

a4acd3e

plugin: fixes structures i according with the serialization

1ec9908

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

plugin: fixed request types

a40242f

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

plugin: draft implementation plugin

864ccb2

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo added the plugin API Plugin API related label Jun 15, 2022

vincenzopalazzo requested a review from swaptr June 15, 2022 23:14

vincenzopalazzo assigned swaptr Jun 15, 2022

vincenzopalazzo added this to In progress in lndart plugin via automation Jun 15, 2022

vincenzopalazzo changed the title ~~implementing draft method like getmanifest to be able to run the plugin~~ implementing life cycle rpc method like getmanifest to be able to run the plugin Jun 15, 2022

This was referenced Jun 15, 2022

plugin: implement rpc request parsing and plugin init. #22

Closed

plugin: fixes structures i according with the serialization #25

Closed

plugin: fixes structures i according with the serialization

fff8a38

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo force-pushed the macros/plugin branch from c6b5c23 to fff8a38 Compare June 15, 2022 23:19

vincenzopalazzo commented Jun 15, 2022

View reviewed changes

packages/cln_plugin/.gitignore Show resolved Hide resolved

packages/cln_plugin/lib/src/cln_plugin_base.dart Outdated Show resolved Hide resolved

packages/cln_plugin/lib/src/cln_plugin_base.dart Outdated Show resolved Hide resolved

swaptr reviewed Jun 16, 2022

View reviewed changes

packages/cln_plugin/lib/src/cln_plugin_base.dart Outdated Show resolved Hide resolved

vincenzopalazzo commented Jun 16, 2022

View reviewed changes

packages/cln_plugin/lib/src/cln_plugin_base.dart Outdated Show resolved Hide resolved

vincenzopalazzo force-pushed the macros/plugin branch from 21f683f to c5505d4 Compare June 16, 2022 17:12

plugin: store content of the init method

dc9922b

Co-authored-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

vincenzopalazzo force-pushed the macros/plugin branch from c5505d4 to dc9922b Compare June 16, 2022 17:17

vincenzopalazzo merged commit 01bd437 into main Jun 16, 2022

lndart plugin automation moved this from In progress to Done Jun 16, 2022

vincenzopalazzo mentioned this pull request Jun 16, 2022

plugin: check how the notification are encoded inside the getmanifest method #32

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implementing life cycle rpc method like getmanifest to be able to run the plugin #26

implementing life cycle rpc method like getmanifest to be able to run the plugin #26

vincenzopalazzo commented Jun 15, 2022 •

edited

swaptr Jun 16, 2022

vincenzopalazzo Jun 16, 2022

swaptr Jun 16, 2022

vincenzopalazzo Jun 16, 2022

swaptr Jun 16, 2022

vincenzopalazzo Jun 16, 2022

swaptr Jun 16, 2022

vincenzopalazzo Jun 16, 2022

vincenzopalazzo Jun 15, 2022

vincenzopalazzo Jun 15, 2022

vincenzopalazzo Jun 16, 2022

swaptr Jun 16, 2022

vincenzopalazzo Jun 16, 2022

vincenzopalazzo Jun 16, 2022

	response["notifications"] = [];
	response["notifications"] = [];

implementing life cycle rpc method like getmanifest to be able to run the plugin #26

implementing life cycle rpc method like getmanifest to be able to run the plugin #26

Conversation

vincenzopalazzo commented Jun 15, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vincenzopalazzo commented Jun 15, 2022 •

edited