Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows.Data.Xml.Dom #246

Closed
wants to merge 1 commit into from
Closed

Support Windows.Data.Xml.Dom #246

wants to merge 1 commit into from

Conversation

Sunbreak
Copy link
Contributor

Signed-off-by: Sunbreak sunbreak.wang@gmail.com

@Sunbreak
Add IXmlNodeList
b6970cb 
Signed-off-by: Sunbreak <sunbreak.wang@gmail.com>
@Sunbreak
Copy link
Contributor Author

I'm porting https://github.com/mohabouje/WinToast to Dart/Flutter, which needs Windows.Data.Xml.Dom features

When add Windows.Data.Xml.Dom there're several problems, could you take a look? @timsneath

Sunbreak
Sunbreak commented Jun 11, 2021
View reviewed changes
lib/src/com/IXmlNodeList.dart

/// {@category Interface}
/// {@category winrt}
class IXmlNodeList {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IXmlNodeList is a subtype of IInspectable but the generation omit the inheritance

@timsneath how could I dig inside? Or should I add the inheritance manually?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like IXmlNodeList implements IReadOnlyList<IXmlNode> and IEnumerable<IXmlNode>. I think my projection code is broken for WinRT interfaces with generics at present, so it doesn't know what to do.

Curious though -- can't you use the Dart xml package to parse the XML? I think that's going to be easier...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #247.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #247.

Thanks a lot

Curious though -- can't you use the Dart xml package to parse the XML? I think that's going to be easier...

IToastNotificationManagerStatics's GetTemplateContent results in a IXmlDocument. So I guess I have to use Windows.Data.Xml.Dom

This was referenced Jun 19, 2021
Closed
Open
@timsneath timsneath mentioned this pull request May 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsneath timsneath timsneath left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sunbreak @timsneath