Fix flaky crashes related to Finalizers in tests #804

halildurmus · 2023-12-19T22:15:02Z

Updates the Finalizer callback to decrement the reference count of the object only when COM is initialized
Resolves issues in tests that were leading to program crashes, along with various cleanup tasks
Implements a mechanism to guarantee the execution of Finalizers after tests, thus preventing the recurrence of such crashes in the future

halildurmus changed the base branch from fix-leaks to main December 19, 2023 22:15

halildurmus marked this pull request as ready for review December 19, 2023 22:17

halildurmus marked this pull request as draft December 19, 2023 22:17

halildurmus force-pushed the experiment branch from 8d93788 to 951c067 Compare December 19, 2023 23:40

domesticmouse approved these changes Dec 20, 2023

View reviewed changes

halildurmus added 2 commits December 20, 2023 16:06

Release the object only if COM is initialized

8a37e6b

Fix flaky crashes related to Finalizers in tests and some cleanup

9982445

halildurmus force-pushed the experiment branch from 0b4b0dd to 9982445 Compare December 20, 2023 13:07

halildurmus changed the title ~~EXPERIMENT~~ Fix flaky crashes related to Finalizers in tests Dec 20, 2023

halildurmus marked this pull request as ready for review December 20, 2023 13:17

halildurmus requested a review from domesticmouse December 20, 2023 13:18

halildurmus added the quality label Dec 20, 2023

domesticmouse approved these changes Dec 20, 2023

View reviewed changes

halildurmus merged commit cb3f27b into main Dec 20, 2023
4 checks passed

halildurmus deleted the experiment branch December 20, 2023 19:21

Provide feedback