Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove db config option from core & replace header string with HttpHeaders class #49

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Remove db config option from core & replace header string with HttpHeaders class #49

merged 3 commits into from
Jul 22, 2023

Conversation

necessarylion
Copy link
Member

  • Since Db config can be set in config/database.dart, it doesn't really necessary to set from app config.

  • Replace header strings with HttpHeaders class

@github-actions
Copy link
Contributor

Coverage after merging remove-db-config-option-from-core into develop

76.69%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
lib
   app.dart100%100%82.50%..., 70, 71, 92, 93
lib/cache
   cache.dart100%100%100%
   cache_driver_interface.dart100%100%0%..., 16, 4, 6, 8
   file_cache_driver.dart100%100%100%
lib/env
   env.dart100%100%100%
lib/exception
   http_exception.dart100%100%100%
   internal_error_exception.dart100%100%100%
   not_found_exception.dart100%100%100%
   query_exception.dart100%100%100%
   unauthorized_exception.dart100%100%100%
   validation_exception.dart100%100%100%
lib/http
   http_controller_handler.dart100%100%89.19%20, 25, 27, 32
   http_request_handler.dart100%100%82.14%..., 74, 76, 86, 87
   http_response_handler.dart100%100%80%29, 30, 51, 52
lib/http/request
   form_request.dart100%100%13.95%..., 92, 93, 97, 98
   dox_request.dart100%100%57.89%..., 234, 235, 237, 85
   request_file.dart100%100%0%..., 48, 49, 50, 7
   http_request_body.dart100%100%76.92%14, 15, 16
   form_data_visitor.dart100%100%0%..., 75, 78, 79, 82
lib/http/response
   dox_cookie.dart100%100%100%
   dox_response.dart100%100%100%
   serializer.dart100%100%86.67%18, 19
lib/interfaces
   router.dart100%100%50%2
   app_config.dart100%100%33.33%27, 29
   auth.dart100%100%0%14, 26, 5, 7
   dox_service.dart100%100%0%4
lib/ioc
   ioc_container.dart100%100%100%
lib/multi_thread
   multi_thread.dart100%100%100%
   multi_thread_interfaces.dart100%100%100%
   multi_thread_isolate_handler.dart100%100%100%
lib/router
   route.dart100%100%86.90%..., 93, 94, 95, 98
   route_data.dart100%100%100%
lib/server
   dox_server.dart100%100%90.63%31, 73, 85
lib/utils
   aes_encryptor.dart100%100%100%
   extensions.dart100%100%100%
   hash.dart100%100%100%
   logger.dart100%100%40%..., 27, 28, 3, 4
   utils.dart100%100%100%
lib/validation
   dox_validator.dart100%100%93.02%102, 33, 38
   nested_validation_visitor.dart100%100%100%
   validation_item.dart100%100%100%
   validation_rules.dart100%100%78.57%..., 286, 95, 97, 98
lib/websocket
   socket_emitter.dart100%100%6.25%..., 55, 56, 58, 59
   dox_websocket.dart100%100%88%59, 65, 66
   socket_storage.dart100%100%89.29%60, 69, 70
   web_socket_info.dart100%100%100%

@github-actions
Copy link
Contributor

Coverage after merging remove-db-config-option-from-core into develop

76.69%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
lib
   app.dart100%100%82.50%..., 70, 71, 92, 93
lib/cache
   cache.dart100%100%100%
   cache_driver_interface.dart100%100%0%..., 16, 4, 6, 8
   file_cache_driver.dart100%100%100%
lib/env
   env.dart100%100%100%
lib/exception
   http_exception.dart100%100%100%
   internal_error_exception.dart100%100%100%
   not_found_exception.dart100%100%100%
   query_exception.dart100%100%100%
   unauthorized_exception.dart100%100%100%
   validation_exception.dart100%100%100%
lib/http
   http_controller_handler.dart100%100%89.19%20, 25, 27, 32
   http_request_handler.dart100%100%82.14%..., 74, 76, 86, 87
   http_response_handler.dart100%100%80%29, 30, 51, 52
lib/http/request
   form_request.dart100%100%13.95%..., 92, 93, 97, 98
   dox_request.dart100%100%57.89%..., 234, 235, 237, 85
   request_file.dart100%100%0%..., 48, 49, 50, 7
   http_request_body.dart100%100%76.92%14, 15, 16
   form_data_visitor.dart100%100%0%..., 75, 78, 79, 82
lib/http/response
   dox_cookie.dart100%100%100%
   dox_response.dart100%100%100%
   serializer.dart100%100%86.67%18, 19
lib/interfaces
   router.dart100%100%50%2
   app_config.dart100%100%33.33%27, 29
   auth.dart100%100%0%14, 26, 5, 7
   dox_service.dart100%100%0%4
lib/ioc
   ioc_container.dart100%100%100%
lib/multi_thread
   multi_thread.dart100%100%100%
   multi_thread_interfaces.dart100%100%100%
   multi_thread_isolate_handler.dart100%100%100%
lib/router
   route.dart100%100%86.90%..., 93, 94, 95, 98
   route_data.dart100%100%100%
lib/server
   dox_server.dart100%100%90.63%31, 73, 85
lib/utils
   aes_encryptor.dart100%100%100%
   extensions.dart100%100%100%
   hash.dart100%100%100%
   logger.dart100%100%40%..., 27, 28, 3, 4
   utils.dart100%100%100%
lib/validation
   dox_validator.dart100%100%93.02%102, 33, 38
   nested_validation_visitor.dart100%100%100%
   validation_item.dart100%100%100%
   validation_rules.dart100%100%78.57%..., 286, 95, 97, 98
lib/websocket
   socket_emitter.dart100%100%6.25%..., 55, 56, 58, 59
   dox_websocket.dart100%100%88%59, 65, 66
   socket_storage.dart100%100%89.29%60, 69, 70
   web_socket_info.dart100%100%100%

@github-actions
Copy link
Contributor

Coverage after merging remove-db-config-option-from-core into develop

76.69%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
lib
   app.dart100%100%82.50%..., 70, 71, 92, 93
lib/cache
   cache.dart100%100%100%
   cache_driver_interface.dart100%100%0%..., 16, 4, 6, 8
   file_cache_driver.dart100%100%100%
lib/env
   env.dart100%100%100%
lib/exception
   http_exception.dart100%100%100%
   internal_error_exception.dart100%100%100%
   not_found_exception.dart100%100%100%
   query_exception.dart100%100%100%
   unauthorized_exception.dart100%100%100%
   validation_exception.dart100%100%100%
lib/http
   http_controller_handler.dart100%100%89.19%20, 25, 27, 32
   http_request_handler.dart100%100%82.14%..., 74, 76, 86, 87
   http_response_handler.dart100%100%80%29, 30, 51, 52
lib/http/request
   form_request.dart100%100%13.95%..., 92, 93, 97, 98
   dox_request.dart100%100%57.89%..., 234, 235, 237, 85
   request_file.dart100%100%0%..., 48, 49, 50, 7
   http_request_body.dart100%100%76.92%14, 15, 16
   form_data_visitor.dart100%100%0%..., 75, 78, 79, 82
lib/http/response
   dox_cookie.dart100%100%100%
   dox_response.dart100%100%100%
   serializer.dart100%100%86.67%18, 19
lib/interfaces
   router.dart100%100%50%2
   app_config.dart100%100%33.33%27, 29
   auth.dart100%100%0%14, 26, 5, 7
   dox_service.dart100%100%0%4
lib/ioc
   ioc_container.dart100%100%100%
lib/multi_thread
   multi_thread.dart100%100%100%
   multi_thread_interfaces.dart100%100%100%
   multi_thread_isolate_handler.dart100%100%100%
lib/router
   route.dart100%100%86.90%..., 93, 94, 95, 98
   route_data.dart100%100%100%
lib/server
   dox_server.dart100%100%90.63%31, 73, 85
lib/utils
   aes_encryptor.dart100%100%100%
   extensions.dart100%100%100%
   hash.dart100%100%100%
   logger.dart100%100%40%..., 27, 28, 3, 4
   utils.dart100%100%100%
lib/validation
   dox_validator.dart100%100%93.02%102, 33, 38
   nested_validation_visitor.dart100%100%100%
   validation_item.dart100%100%100%
   validation_rules.dart100%100%78.57%..., 286, 95, 97, 98
lib/websocket
   socket_emitter.dart100%100%6.25%..., 56, 57, 59, 60
   dox_websocket.dart100%100%88%56, 62, 63
   socket_storage.dart100%100%89.29%60, 69, 70
   web_socket_info.dart100%100%100%

@necessarylion necessarylion merged commit 3295823 into develop Jul 22, 2023
2 checks passed
@necessarylion necessarylion deleted the remove-db-config-option-from-core branch July 22, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@necessarylion