Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create validator for IPv4 addresses #149

Merged
merged 1 commit into from Dec 18, 2021
Merged

Conversation

rafamizes
Copy link
Member

Closes #97

@rafamizes rafamizes added the feature A new feature label Dec 18, 2021
@rafamizes rafamizes self-assigned this Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #149 (d997630) into master (3dc92b1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        43    +2     
  Lines          397       409   +12     
=========================================
+ Hits           397       409   +12     
Impacted Files Coverage Δ
lib/src/net/ipv4.dart 100.00% <100.00%> (ø)
lib/src/net/req_ipv4.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc92b1...d997630. Read the comment docs.

@rafamizes
Copy link
Member Author

@rultor merge it.

@rultor
Copy link
Collaborator

rultor commented Dec 18, 2021

@rultor merge it.

@rafamizes OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d997630 into dartoos-dev:master Dec 18, 2021
@rultor
Copy link
Collaborator

rultor commented Dec 18, 2021

@rultor merge it.

@rafamizes Done! FYI, the full log is here (took me 2min)

@rafamizes rafamizes deleted the ipv4 branch December 18, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ipv4 validator
2 participants