Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated sdk constraints and removed warnings #138

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

bryansantosdeve
Copy link
Collaborator

refactor: updated sdk constraints and removed warnings

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #138 (8fb6baf) into master (6c46a17) will not change coverage.
The diff coverage is n/a.

❗ Current head 8fb6baf differs from pull request most recent head 06ec42d. Consider uploading reports for the commit 06ec42d to get more accurate results

@@            Coverage Diff            @@
##            master      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          197       197           
=========================================
  Hits           197       197           

@bryansantosdeve
Copy link
Collaborator Author

Changes on pubspec.yaml and analysis_options.yaml :

  • SDK constraints updated from ">=2.12.0 <3.0.0" to ">=2.16.0 <3.0.0".
  • Due to SDK >=3.0.0 on constraints and some imcompatibilities with lint package, it required to override the "analyze" options with strong-mode. Since lint upgraded to v2.1.0, the implicit-casts option was removed. The same point was discussed on this issue. In this case, update the project totally to Dart3 could be adequate to current scenario of packages available on community.

If there are any points in mind, please, let me know!

@rafamizes rafamizes merged commit 168bbd6 into dartoos-dev:master Aug 9, 2023
1 check passed
@bryansantosdeve bryansantosdeve added the refactor A code change that neither fixes a bug nor adds a feature label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants