Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move towards code quality A+ #37

Merged
merged 1 commit into from Aug 17, 2021
Merged

refactor: move towards code quality A+ #37

merged 1 commit into from Aug 17, 2021

Conversation

rafamizes
Copy link
Member

Closes #36

@rafamizes rafamizes added refactor A code change that neither fixes a bug nor adds a feature style Changes that do not affect the meaning of the code (white-space, formatting, etc)) labels Aug 17, 2021
@rafamizes rafamizes self-assigned this Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #37 (0631e61) into master (9a87170) will increase coverage by 1.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   92.00%   93.29%   +1.29%     
==========================================
  Files           9        9              
  Lines         200      194       -6     
==========================================
- Hits          184      181       -3     
+ Misses         16       13       -3     
Impacted Files Coverage Δ
lib/src/core/basic_text_field.dart 92.00% <ø> (ø)
lib/src/core/well_formed.dart 73.17% <ø> (ø)
lib/src/brazil/cep_field.dart 100.00% <100.00%> (+5.88%) ⬆️
lib/src/brazil/cnpj_field.dart 100.00% <100.00%> (+5.55%) ⬆️
lib/src/brazil/cpf_field.dart 100.00% <100.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a87170...0631e61. Read the comment docs.

@rafamizes
Copy link
Member Author

@rultor merge it.

@rultor
Copy link
Collaborator

rultor commented Aug 17, 2021

@rultor merge it.

@rafamizes OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 0631e61 into dartoos-dev:master Aug 17, 2021
@rultor
Copy link
Collaborator

rultor commented Aug 17, 2021

@rultor merge it.

@rafamizes Done! FYI, the full log is here (took me 3min)

@rafamizes rafamizes deleted the 36 branch August 17, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature style Changes that do not affect the meaning of the code (white-space, formatting, etc))
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move towards A+ code quality
2 participants