Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebStorm says that AppActions is not declared in imported module. #14

Closed
LarryEitel opened this issue Aug 10, 2015 · 11 comments
Closed

Comments

@LarryEitel
Copy link
Contributor

'...\app\actions\AppActions.js' line 5:

import AppActions from '../../actions/AppActions';

WebStorm complains/suggests that AppActions Default export is not declared in imported module.

Just a curious message.

@darul75
Copy link
Owner

darul75 commented Aug 10, 2015

nice catch WebStorm is so strong, I will keep a look, may be caused by ES6 new features http://www.2ality.com/2014/09/es6-modules-final.html
but normally just a warning

@LarryEitel
Copy link
Contributor Author

I figured that much. I am new at ES6 as well. I'm using your project to learn. :) I looked at many but yours includes the key pieces I'm looking for. Especially do I appreciate your $ajax example.

@darul75
Copy link
Owner

darul75 commented Aug 10, 2015

nice, me too I have learned by creating it, inspect, play, redo, good for both of us, you will build website quickly, enjoy Larry. do not hesitate

@LarryEitel
Copy link
Contributor Author

Changing in AppActions
module.exports = alt.createActions(AppActions);

To:
export default alt.createActions(AppActions);

Makes WebStorm happier and doesn't seem to break anything.

Thoughts?

@darul75
Copy link
Owner

darul75 commented Aug 11, 2015

yes it is but I will add it later, thx Larry, or do not hesitate put a PR for it

@LarryEitel
Copy link
Contributor Author

I am finding more places where same refactoring is required. Will submit a PR next chance.

@darul75
Copy link
Owner

darul75 commented Aug 11, 2015

👍
sure a big refactoring is needed and it is difficult to make it alone :)

@LarryEitel
Copy link
Contributor Author

Happy to help where/when I can. Are you open to discuss via Hangout/Skype?

On Tue, Aug 11, 2015 at 9:33 AM, Julien Valéry notifications@github.com
wrote:

[image: 👍]
sure a big refactoring is needed and it is difficult to make it alone :)


Reply to this email directly or view it on GitHub
#14 (comment).

@darul75
Copy link
Owner

darul75 commented Aug 11, 2015

I would like so much but it is blocked by our company proxy there ;) otherwise on darul75@gmail.com when at home

@LarryEitel
Copy link
Contributor Author

Hello @darul75, been MIA on this project because I have been focusing on Redux vs Alt.

@Fauzdar1
Copy link

Same issue with PHPStorm, messing things up here and then. Most of the times, it works and then suddenly stops working. Solution is to duplicate it and change the name, and it starts working again. Seriously, a mess.

I'm using it for multiple exports as

module.exports = {
...
...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants