Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify implementation of Middleware Compose
The implementation of middleware compose is duplicating behavior already in compose. `(apply comp [])` returns identity.
- Loading branch information
9326a41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke todomvc example. For example this call:
https://github.com/Day8/re-frame/blob/b566c08f40d0485941e8e06f7678e8064563cde3/examples/todomvc/src/todomvc/handlers.cljs#L53
Vector of middlewares is passed in which gets into comp-middleware as "v" param. (seq? v) returns false and :else branch is executed.
9326a41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw. fixed it in my branch here:
329a57f