Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Separate StakingLock from StakingLedger #121

Closed
AurevoirXavier opened this issue Apr 30, 2020 · 3 comments · Fixed by #1187
Closed

Separate StakingLock from StakingLedger #121

AurevoirXavier opened this issue Apr 30, 2020 · 3 comments · Fixed by #1187
Assignees
@AurevoirXavier

Comments

@AurevoirXavier
Copy link
Member

No description provided.

@AurevoirXavier
Copy link
Member Author

AurevoirXavier commented Apr 30, 2020 •
edited

bond(new ledger) will overwrite the locks after unbond(all stake).

except: reap_stash and force_unstake, these are reasonable.

@hackfisher
Copy link
Contributor

hackfisher commented Apr 30, 2020 •
edited

Related #122

I tend to keep the current struct and do the general reap stuff in a stand alone trait, not specific for Lock, but for storages of each module.

AurevoirXavier added a commit that referenced this issue Apr 30, 2020
@AurevoirXavier
fixme: #121
15acd29
@hackfisher hackfisher added the P-Mid [Priority] Median label Aug 17, 2021
@AurevoirXavier
Copy link
Member Author

https://github.com/darwinia-network/darwinia-common/pull/799/files#diff-847a61d013ce4aedef41be8e70a2b09d96eb3ac5d5ce3d3da45e03915ab1fa90 Could be optimized by this.

@AurevoirXavier AurevoirXavier removed the P-Mid [Priority] Median label Apr 20, 2022
@AurevoirXavier AurevoirXavier linked a pull request Apr 20, 2022 that will close this issue
Use Parity LockableCurrency #1187
Merged
12 tasks
@AurevoirXavier AurevoirXavier self-assigned this Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AurevoirXavier AurevoirXavier

Labels
None yet
Projects
No open projects
Darwinia Release
Status: Done/No Companion
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Parity LockableCurrency darwinia-network/darwinia-common
2 participants
@hackfisher @AurevoirXavier