This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
Merge withdraw and kton into new transfer precompile #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
boundless-forest
requested review from
AurevoirXavier,
hackfisher and
xiaoch05
as code owners
June 1, 2021 08:52
boundless-forest
force-pushed
the
bear-precompiles-to-one
branch
from
June 1, 2021 14:11
c817c3a
to
4e1d0b3
Compare
One question, does |
|
Good questioin. The answer from AurevoirXavier Element: > bear | Darwinia Network
Can i use usize type for number in pallet?
> Xavier - Darwinia.Network
Yes
But in WASM it's u32
So make sure it won't be grow up to u32::max_value + 1 I also find some examples from substrate:
In the end, I think this usage is ok. |
hackfisher
reviewed
Jun 3, 2021
hackfisher
suggested changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sxlwar please ACK these changes, might require companion PR in smart-app later.
boundless-forest
force-pushed
the
bear-precompiles-to-one
branch
from
June 8, 2021 11:48
ece7559
to
1ff55c9
Compare
boundless-forest
force-pushed
the
bear-precompiles-to-one
branch
from
June 9, 2021 03:49
c49f7de
to
1922adb
Compare
hackfisher
reviewed
Jun 15, 2021
hackfisher
suggested changes
Jun 15, 2021
hackfisher
reviewed
Jun 15, 2021
hackfisher
changed the title
Merge wtithdraw and kton into new transfer precompile
Merge withdraw and kton into new transfer precompile
Jun 15, 2021
hackfisher
approved these changes
Jun 15, 2021
@AurevoirXavier Please review this pr again. |
AurevoirXavier
approved these changes
Jun 22, 2021
hujw77
added a commit
to evolutionlandorg/token-contracts
that referenced
this pull request
Jun 23, 2021
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I merged the original
withdraw
precompile(0x15) and thekton
precompile(0x16) into a new precompile contract, namedtransfer
, which address is 0x15, the same as with the original withdraw precompile address.Something important to notice:
I did not change the protocol of old precompiles. For application users who use kton precompile, just update the kton precompile address from 0x16 to 0x15. @hujw77 @sxlwar We should update wkton contract before this change goes to pangolin.