Refactor Ethereum Primitives

[AurevoirXavier]

• Drop duplicate primitive library.

   // e.g.
   // `H64`, `H256` from different library
   use primitive_types::H64;
   use ethereum_types::H256;

• Clean unnecessary dependencies speed up the compiling.
• Generic library with multi-features control, easy to use for side projects such as bridger, shadow, etc.
• Better error handling.
• Remove EthereumHeader::from_str_unchecked #271
  • New serializer/deserializer accept all Infura API like header spec. With this feature added, shadow does not need to handle the DarwiniaHeader spec. And we could finish the serialize/deserialize in bridger part with library ethereum-primitives. cc @xiaoch05
• Ethereum London Hardfork support #702
  • Support EIP-1559 #701
    • On-chain storage checks. There is a new field named base_fee_per_gas, which type is an Option. Maybe it's compatible with scale-codec.
    • Migration to new header spec.
      • New header spec.
      • Impl RLP encoder/decoder for new header.
      • Reset Relay::ConfirmedHeaderParcels.
      • Reset RelayerGame::Affirmations.
  • Support EIP-3554.
    • Add difficulty bomb delay.
• Maybe Refactor ethereum-primitives & chain-bsc #655.

[hackfisher]

Ethereum and BSC may use different version of primitives, not reasonable to merge and unify them, any tiny upgrade from chain side changing the primitives could break this.

[AurevoirXavier]

panicked at 'called `Result::unwrap()` on an `Err` value: Error { cause: Some(Error { cause: Some(Error { cause: None, desc: "Not enough data to fill buffer" }), desc: "Could not decode variant byte for `Option`" }), desc: "Could not decode `Header::hash`" }'

EIP-1559 introduces a new field in the header base_fee_per_gas, which will break the scale-type encoded storage.

For us, we could clear the ConfirmedHeaderParcels storage then apply the new type. Or define a new storage name. (e.g. EIP1559HeaderParcels).

cc @hackfisher

[hackfisher]

panicked at 'called `Result::unwrap()` on an `Err` value: Error { cause: Some(Error { cause: Some(Error { cause: None, desc: "Not enough data to fill buffer" }), desc: "Could not decode variant byte for `Option`" }), desc: "Could not decode `Header::hash`" }'

EIP-1559 introduces a new field in the header base_fee_per_gas, which will break the scale-type encoded storage.

For us, we could clear the ConfirmedHeaderParcels storage then apply the new type. Or define a new storage name. (e.g. EIP1559HeaderParcels).

cc @hackfisher

Prefer clear & migrate the ConfirmedHeaderParcels storage then apply the new type.

[AurevoirXavier]

The genesis's MMR root is wrong.
Need shadow to provide the right one.

cc @xiaoch05

[AurevoirXavier]

It's safe to use remove_all and kill. Doesn't relate to the type but the prefixes.

https://crates.parity.io/sp_externalities/trait.Externalities.html#tymethod.clear_prefix
https://crates.parity.io/frame_support/storage/trait.StorageValue.html#impl-StorageValue%3CT%3E

[hackfisher]

This looks not right, compared to https://github.com/openethereum/openethereum/pull/561/files#diff-06bc3942f66cb315836147192afb41985b91ee270161b398f69a2d07fd4ddc05R141

[AurevoirXavier]

I forgot where I got these values.
Should we update this to the latest openethereum code in the next runtime upgrade?

[hackfisher]

Yes, I double checked with geth, openethereum's code should be right.

[AurevoirXavier]

Should this be included in darwinia-v0.11.7?
I'll fire a PR right now.

[hackfisher]

OK, darwinia-v0.11.7 branch is a good place, and don't forget we also need it in master.