Audit changes #273
Merged
Audit changes #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hujw77
commented
Sep 19, 2022
•
hujw77
commented
- decrease collateral per-order
- remove dead code
- add beacon light client mandatory reward
- remove unused payble modifier, prevent user lock assert forever but little gas increased.
- increase last_delivered_nonce after dispath
- make DUTY_REWARD_RATIO immutable
- outbounlane send_message return latest_generated_nonce
- increase MAX_GAS_PER_MESSAGE to 24w
hackfisher
reviewed
Sep 20, 2022
hackfisher
reviewed
Sep 20, 2022
hackfisher
approved these changes
Sep 23, 2022
| return IBeaconLightClient(consensusLayer).sync_committee_roots(next_period) != bytes32(0); | ||
| } | ||
|
|
||
| function import_mandatory_next_sync_committee_for_reward( |
There was a problem hiding this comment.
Add docs about prepare works before do this operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.