Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review: Account's References #317

Closed
AurevoirXavier opened this issue Mar 5, 2020 · 3 comments
Closed

Review: Account's References #317

AurevoirXavier opened this issue Mar 5, 2020 · 3 comments
Assignees
@AurevoirXavier

Comments

@AurevoirXavier
Copy link
Member

Due to Lazy Reaping.
@hackfisher
Copy link
Contributor

https://github.com/paritytech/substrate/blob/9c59bcdb21/frame/contracts/src/lib.rs#L948

https://github.com/paritytech/substrate/blob/9c59bcdb21b3e71759f2e4a02911250224805362/frame/contracts/src/tests.rs#L120

BTW, we should document a best practice for these security checkings.

@AurevoirXavier
Copy link
Member Author

AurevoirXavier commented Mar 5, 2020 •
edited
Loading

Maybe we can use OnKilledAccount to collect the locks.

@AurevoirXavier
Copy link
Member Author

Move to #353.

@AurevoirXavier AurevoirXavier self-assigned this Mar 17, 2020
boundless-forest pushed a commit that referenced this issue Aug 1, 2023
@sorpaas
Move manual seal node template under a feature flag (#317)
c1694f4 
* Move manual seal node template under a feature flag

* Fix feature propogation

* Fix tests

* [WIP] Log GA-generated contract bytecode for debugging

* [WIP] Comment out middle steps for faster debugging

* Switch to dockerized truffle build

* [WIP] Try a different solidity version

* Remove debug GA workflow code

* Remove bytecode match check in tests

* Fix tests due to solc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurevoirXavier AurevoirXavier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackfisher @AurevoirXavier