Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finality-tracker pallet module to crab runtime #420

Closed
hackfisher opened this issue Apr 9, 2020 · 1 comment · Fixed by #421
Closed

Add finality-tracker pallet module to crab runtime #420

hackfisher opened this issue Apr 9, 2020 · 1 comment · Fixed by #421
Assignees
@AurevoirXavier
Projects
Crab Network Tasks

Comments

@hackfisher
Copy link
Contributor

Can help give more info and hints of finality.

Related #419
@hackfisher hackfisher changed the title Add finality-tracker to crab runtime Add finality-tracker pallet module to crab runtime Apr 9, 2020
@hackfisher hackfisher added this to To do in Crab Network Tasks via automation Apr 9, 2020
@hackfisher
Copy link
Contributor Author

Found the module has already been added to runtime, but missing storage.

Not sure this will influence it's on-chain operation, or just can not query for chain state?

Need to add the storage to runtime

FinalityTracker: finality_tracker::{Module, Call, Storage, Inherent},

@AurevoirXavier AurevoirXavier linked a pull request Apr 14, 2020 that will close this issue
Upgrade Substrate #421
Merged
Crab Network Tasks automation moved this from To do to Done Apr 14, 2020
boundless-forest pushed a commit that referenced this issue Aug 1, 2023
@tgmichel @JoshOrndorff
Use reducible_balance instead free_balance (#420)
8139beb 
* Use `tokens::fungible::Inspect::reducible_balance`

* Integration test

* cargo fmt

* integration tests

* recipient's balance is also subject to ed

Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurevoirXavier AurevoirXavier

Labels
None yet
Projects
No open projects
Crab Network Tasks
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Substrate darwinia-network/darwinia
2 participants
@hackfisher @AurevoirXavier