Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to migrate and delete garbage storage in scheduler.agenda(2332800) #665

Closed
hackfisher opened this issue Jun 8, 2021 · 1 comment · Fixed by #662
Closed

how to migrate and delete garbage storage in scheduler.agenda(2332800) #665

hackfisher opened this issue Jun 8, 2021 · 1 comment · Fixed by #662

Comments

@hackfisher
Copy link
Contributor

hackfisher commented Jun 8, 2021 •
edited

darwinia-network/apps#245

https://crab.subscan.io/referenda/1?tab=proposal_preimage

referenda/1 was successfully voted, but its agenda was not deleted after execution(no sure), there are deprecated version of ScheduledV1 which is different with current ScheduledV2

We are not sure whether it is safe to delete the storage without know exactly what's its type.

agendas when block=5600982:

[0x3db7a24cfdc9de785974746c14a99df91643f5419718219c95679ddd2d825574862bc7e6c00ceb4180982300, 0x3db7a24cfdc9de785974746c14a99df91643f5419718219c95679ddd2d8255749c9b2b276dc73066405a5600]

and values:
[0x0401013064656d6f63726163010000003f21165dcfc20d2356679a67cf8d6b4dbba0e75ed35b290e030c85729dd9d0e4fa332101000000000000, 0x0401013064656d6f63726163140000003f2416ae25f392ae08d6977d69b61eef5aa391d91df0ae32d4e4f669059b1112aeda7014000000000000]

the first is referenda/1, the second might be referenda/20
@hackfisher
Copy link
Contributor Author

hackfisher commented Jun 8, 2021 •
edited

https://github.com/paritytech/substrate/blob/d0891796ed48acfad7445b884c8d035dc4a2487a/frame/support/src/storage/unhashed.rs#L28

https://github.com/paritytech/substrate/blob/d0891796ed48acfad7445b884c8d035dc4a2487a/frame/support/src/storage/generator/value.rs#L104

https://github.com/paritytech/substrate/blob/d0891796ed48acfad7445b884c8d035dc4a2487a/frame/support/src/storage/generator/map.rs#L237

@AurevoirXavier
If we use storage kill() or remove() instead of take(), it looks that we does not need to care about the value's type.

@hackfisher hackfisher mentioned this issue Jun 11, 2021
Merged
@AurevoirXavier AurevoirXavier linked a pull request Jul 20, 2021 that will close this issue
Release v0.11.0 #662
Merged
boundless-forest pushed a commit that referenced this issue Aug 1, 2023
@tgmichel
validation primitive (#665)
c2b56a8 
* wip validation primitive

* fmt

* `with_chain_id`

* some cleanup

* use `validate_in_block_for` when in block..

* Update evm runner

* Move validation to module

* check

* Validation tests

* formatting

* clippy

* Runner trait take `chain_id` as arg

* Revert "Runner trait take `chain_id` as arg"

This reverts commit 5a5354b14a555ba475442beda16f0471f0c65f29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v0.11.0 darwinia-network/darwinia
2 participants
@hackfisher @AurevoirXavier