Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing apis #1117

Merged
merged 24 commits into from
Apr 26, 2023
Merged

Add tracing apis #1117

merged 24 commits into from
Apr 26, 2023

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented Apr 23, 2023

Add EVM tracing APIs to all darwinia's runtime.

TODO: Add the tracing test to ci @AurevoirXavier

# setup node
$ cargo build --release -p darwinia --features pangolin-native,evm-tracing
$ ./target/release/darwinia --chain pangolin-dev --tmp --alice --tracing-api debug,trace

# run test
$ cd tests/ethereum
$ npm install
$ npm run test

@boundless-forest boundless-forest linked an issue Apr 23, 2023 that may be closed by this pull request
@boundless-forest boundless-forest changed the title Add tracing api to testnet Add tracing apis Apr 23, 2023
@boundless-forest boundless-forest marked this pull request as ready for review April 25, 2023 06:48
Copy link
Member

@AurevoirXavier AurevoirXavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this style.

Can you make:

crab-evm-tracing = [
  "crab-native",
  ..
]

By the way, I believe that implementing an evm-tracing feature is feasible. This feature can be developed independently of the native components.

We just need to enable them separately.

@boundless-forest
Copy link
Member Author

By the way, I believe that implementing an evm-tracing feature is feasible. This feature can be developed independently of the native components.

Sound like the try-runtime or runtime-benchmarks?

@AurevoirXavier
Copy link
Member

AurevoirXavier commented Apr 25, 2023

Sound like the try-runtime or runtime-benchmarks?

Yep.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AurevoirXavier AurevoirXavier added the C-EVM [Component] Something about EVM label Apr 26, 2023
@AurevoirXavier AurevoirXavier merged commit d4f5d5d into main Apr 26, 2023
7 checks passed
@AurevoirXavier AurevoirXavier deleted the bear-debug-api branch April 26, 2023 08:28
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Check 62d9261 pangolin-dev

Check runtime version

RuntimeVersion {
    spec_name: "Pangolin2",
    impl_name: "DarwiniaOfficialRust",
    authoring_version: 0,
-   spec_version: 6021,
+   spec_version: 6200,
    impl_version: 0,
    transaction_version: 0,
    state_version: 0,
}

Check runtime storage

@github-actions
Copy link

Check 62d9261 crab-dev

Check runtime version

Check runtime storage

@github-actions
Copy link

Check 62d9261 darwinia-dev

Check runtime version

Check runtime storage

@github-actions
Copy link

Check 62d9261 pangoro-dev

Check runtime version

RuntimeVersion {
    spec_name: "Pangoro2",
    impl_name: "DarwiniaOfficialRust",
    authoring_version: 0,
-   spec_version: 6021,
+   spec_version: 6200,
    impl_version: 0,
    transaction_version: 0,
    state_version: 0,
}

Check runtime storage

@AurevoirXavier
Copy link
Member

AurevoirXavier commented Apr 26, 2023

It looks like this breaks the origin evm test?

@boundless-forest
Copy link
Member Author

It looks like this breaks the origin evm test?

The new evm tests(with tracing ts test) are a superset of the original evm test. This means that we don't need to run the original test separately. Setup the node with trace options, then run the new evm tests. If all the tests pass, this means that the evm works well.

boundless-forest pushed a commit that referenced this pull request Aug 1, 2023
* [pallet_transaction_payment] Mirroring substrate node-template

* [pallet_transaction_payment] Restoring ts-tests/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-EVM [Component] Something about EVM
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ethereum debug APIs
2 participants