Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the forward_transact #1445

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented Mar 8, 2024

The forward_transact call is not so friendly because the transaction structure requires are some unnecessary information, such as nonce, gas price. This PR improves this by introducing another dedicated FarwardRequest.

Hopefully this change should be included in the next runtime upgrade.

@boundless-forest boundless-forest linked an issue Mar 8, 2024 that may be closed by this pull request
@boundless-forest boundless-forest marked this pull request as ready for review March 8, 2024 10:04

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Check a5116fa crab-dev

Check runtime version

Check runtime storage

Copy link

Check a5116fa darwinia-dev

Check runtime version

RuntimeVersion {
    spec_name: "Darwinia2",
    impl_name: "DarwiniaOfficialRust",
    authoring_version: 0,
-   spec_version: 6600,
+   spec_version: 6610,
    impl_version: 0,
    transaction_version: 0,
    state_version: 0,
}

Check runtime storage

- Pallet: "BridgeCrabMessages"
- Pallet: "BridgeKusamaGrandpa"
- Pallet: "BridgeKusamaParachain"
- Pallet: "CrabFeeMarket"

Pallet DarwiniaStaking
+ Entry: StorageEntryMetadata { name: "MigrationStartBlock", modifier: Default, ty: Plain(UntrackedSymbol { id: 4, marker: PhantomData<fn() -> core::any::TypeId> }), default: [0, 0, 0, 0], docs: [" Migration starting block."] }

Copy link

Check a5116fa pangolin-dev

Check runtime version

Check runtime storage

@AurevoirXavier AurevoirXavier merged commit 70dd2f0 into main Mar 15, 2024
10 checks passed
@AurevoirXavier AurevoirXavier deleted the bear-refactor-ethtx-forward branch March 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add document about the EthTxForwarder
3 participants