Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust All Spent Requirements #908

Merged
merged 6 commits into from Jun 15, 2022
Merged

Adjust All Spent Requirements #908

merged 6 commits into from Jun 15, 2022

Conversation

AurevoirXavier
Copy link
Member

Close #904.

@AurevoirXavier
Adjust All Spent Requirements
3c93aa7 
Signed-off-by: Xavier Lau <xavier@inv.cafe>
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited

Commit 83fc443

Crab

Check Runtime Version

Runtime Version {
	spec_name: Crab
	impl_name: Darwinia Crab
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​

Darwinia

Check Runtime Version

Runtime Version {
	spec_name: Darwinia
	impl_name: Darwinia
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​
Commit 3c93aa7

Crab

Check Runtime Version

Runtime Version {
	spec_name: Crab
	impl_name: Darwinia Crab
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​

Darwinia

Check Runtime Version

Runtime Version {
	spec_name: Darwinia
	impl_name: Darwinia
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​
Commit 97646c6

Crab

Check Runtime Version

Runtime Version {
	spec_name: Crab
	impl_name: Darwinia Crab
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​

Darwinia

Check Runtime Version

Runtime Version {
	spec_name: Darwinia
	impl_name: Darwinia
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​
Commit 68a5b13

Crab

Check Runtime Version

Runtime Version {
	spec_name: Crab
	impl_name: Darwinia Crab
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​

Darwinia

Check Runtime Version

Runtime Version {
	spec_name: Darwinia
	impl_name: Darwinia
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​
Commit dc0b303

Crab

Check Runtime Version

Runtime Version {
	spec_name: Crab
	impl_name: Darwinia Crab
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​

Darwinia

Check Runtime Version

Runtime Version {
	spec_name: Darwinia
	impl_name: Darwinia
	authoring_version: 0
-	spec_version: 1224
+	spec_version: 1220
	impl_version: 0
	transaction_version: 0
}​

Check Storage Prefix

​

hackfisher
hackfisher reviewed Jun 9, 2022
View reviewed changes
primitives/src/lib.rs Outdated Show resolved Hide resolved
@AurevoirXavier
Copy link
Member Author

AurevoirXavier commented Jun 15, 2022 •
edited

After I look into every pallet.
I found only proxy use the T::X::get() to unreserve the balance.
All the other pallets will store the reserve amount while reserving, and the unreserve amount was read from storage.

@AurevoirXavier
Copy link
Member Author

Merge to prepare for the next runtime upgrade.

If there is any question, open another PR.

@AurevoirXavier AurevoirXavier merged commit bc4b83f into main Jun 15, 2022
@AurevoirXavier AurevoirXavier deleted the xavier-adjust-config branch June 15, 2022 13:11
hackfisher
hackfisher reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher hackfisher left review comments

Assignees

@AurevoirXavier AurevoirXavier

Labels
None yet
Projects
No open projects
Darwinia Release
Status: Done/No Companion
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase democracy MinimumDeposit to 10000 RING for darwinia and 10000 CRAB for crab
2 participants
@AurevoirXavier @hackfisher