Fixes before initial release

darwintantuco · Apr 14, 2022 · b2f198b · b2f198b
1 parent 907c8e1
commit b2f198b
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -4,6 +4,10 @@
 
 Disallow form tags without method post
 
+Prevents sensitive data appearing on URLs
+
+![](demo.png)
+
 ## Installation
 
 You'll first need to install [ESLint](http://eslint.org):
@@ -14,10 +18,18 @@ $ npm i eslint --save-dev
 
 Next, install `eslint-plugin-require-form-method-post`:
 
+### npm
+
 ```
 $ npm install eslint-plugin-require-form-method-post --save-dev
 ```
 
+### yarn
+
+```
+$ yarn add eslint-plugin-require-form-method-post --dev
+```
+
 ## Usage
 
 Add `require-form-method-post` to the plugins section of your `.eslintrc` configuration file. You can omit the `eslint-plugin-` prefix:
@@ -27,3 +39,13 @@ Add `require-form-method-post` to the plugins section of your `.eslintrc` config
   "plugins": ["require-form-method-post"]
 }
 ```
+
+Then configure the rules you want to use under the rules section.
+
+```json
+{
+  "rules": {
+    "require-form-method-post/require-form-method-post": "error"
+  }
+}
+```
diff --git a/demo.png b/demo.png
diff --git a/lib/rules/require-form-method-post.js b/lib/rules/require-form-method-post.js
@@ -2,7 +2,9 @@
 
 function withMethodPost(attributes) {
   const method = (attributes || []).find(
-    (attribute) => attribute.name.name.toLowerCase() === "method"
+    (attribute) =>
+      attribute.type === "JSXAttribute" &&
+      attribute.name.name.toLowerCase() === "method"
   );
 
   return method && method.value.value.toLowerCase() === "post";

diff --git a/tests/lib/rules/require-form-method-post.js b/tests/lib/rules/require-form-method-post.js
@@ -20,11 +20,19 @@ const defaultErrors = [
 ruleTester.run("require-form-method-post", rule, {
   valid: [
     { code: `<form method="post" onSubmit={handleSubmit}></form>` },
+    {
+      code: `<form {...{ className }} data-testid='form' onSubmit={handleSubmit} method="post"></form>`,
+    },
     { code: `<form method="POST"></form>` },
     { code: `<form METHOD="POST"></form>` },
   ],
   invalid: [
-    { code: `<form onSubmit={handleSubmit}></form>`, errors: defaultErrors },
+    { code: `<form></form>`, errors: defaultErrors },
     { code: `<form method="get"></form>`, errors: defaultErrors },
+    { code: `<form onSubmit={handleSubmit}></form>`, errors: defaultErrors },
+    {
+      code: `<form {...{ className }} data-testid='form' onSubmit={handleSubmit}></form>`,
+      errors: defaultErrors,
+    },
   ],
 });