New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Restore libxml error handler and clear errors #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using libxml_use_internal_errors(true), errors pile up in an internal error handler. When not resetting errors using libxml_clear_errors(), subsequent libxml usages may fail. The patch properly restores the previous libxml error handler value and clears errors.
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Apr 14, 2023
External "enshrined/svg-sanitize" package uses `libxml_use_internal_errors()`, but fails to clear errors using libxml_clear_errors(). This can lead to side effects with subsequest libxml usages. An upstream patch to fix this is pending, but it needs to be merged and released. In the meantime, we mitigate the issue in our wrapper class. See: darylldoyle/svg-sanitizer#90 Resolves: #100607 Releases: main, 11.5 Change-Id: I911119b498a4dda8312c5ca940b5fdf6410a1a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78647 Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Apr 14, 2023
External "enshrined/svg-sanitize" package uses `libxml_use_internal_errors()`, but fails to clear errors using libxml_clear_errors(). This can lead to side effects with subsequest libxml usages. An upstream patch to fix this is pending, but it needs to be merged and released. In the meantime, we mitigate the issue in our wrapper class. See: darylldoyle/svg-sanitizer#90 Resolves: #100607 Releases: main, 11.5 Change-Id: I911119b498a4dda8312c5ca940b5fdf6410a1a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78648 Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Apr 14, 2023
External "enshrined/svg-sanitize" package uses `libxml_use_internal_errors()`, but fails to clear errors using libxml_clear_errors(). This can lead to side effects with subsequest libxml usages. An upstream patch to fix this is pending, but it needs to be merged and released. In the meantime, we mitigate the issue in our wrapper class. See: darylldoyle/svg-sanitizer#90 Resolves: #100607 Releases: main, 11.5 Change-Id: I911119b498a4dda8312c5ca940b5fdf6410a1a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78647 Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Apr 14, 2023
External "enshrined/svg-sanitize" package uses `libxml_use_internal_errors()`, but fails to clear errors using libxml_clear_errors(). This can lead to side effects with subsequest libxml usages. An upstream patch to fix this is pending, but it needs to be merged and released. In the meantime, we mitigate the issue in our wrapper class. See: darylldoyle/svg-sanitizer#90 Resolves: #100607 Releases: main, 11.5 Change-Id: I911119b498a4dda8312c5ca940b5fdf6410a1a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78648 Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
ohader
approved these changes
Apr 15, 2023
kdambekalns
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 by 👀
dlubitz
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using libxml_use_internal_errors(true), errors pile up in an internal error handler. When not
resetting errors using libxml_clear_errors(),
subsequent libxml usages may fail.
The patch properly restores the previous libxml
error handler value and clears errors.