Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New code for log-y-axis when 1.5 cycles is visible doesn't work well with log-x-axis #51

Closed
2 tasks done
jbfaden opened this issue Feb 28, 2023 · 7 comments
Closed
2 tasks done

Comments

@jbfaden
Copy link
Member

jbfaden commented Feb 28, 2023

There's new code to calculate labels for the y axis when it is log and has a small number of cycles (0.5 to 5 for example), and it messes up when the x axis is log, at least when they are connected by a DataRange object.

Also the new code doesn't consider the height when calculating ticks. This should also be resolved.

  • xaxis logic
  • yaxis height
@jbfaden
Copy link
Member Author

jbfaden commented Mar 23, 2023

This is looking better now, and considers the number of ticks to target.

jbfaden added a commit that referenced this issue Mar 23, 2023
of ticks that can fit in the space
jbfaden added a commit that referenced this issue Mar 23, 2023
of ticks that can fit in the space
jbfaden added a commit that referenced this issue Mar 24, 2023
of ticks that can fit in the space.  Back off change before studying
jenkins.
@jbfaden
Copy link
Member Author

jbfaden commented Mar 26, 2023

I'm backing this out until next week, since this needs to be done early in the day because so many Autoplot tests fail.

jbfaden added a commit that referenced this issue Mar 26, 2023
jbfaden added a commit that referenced this issue Apr 18, 2023
again so we can study Autoplot jenkins tests.
@jbfaden
Copy link
Member Author

jbfaden commented Apr 18, 2023

new 1.5-cycle log ticks code introduced again and Autoplot jenkins tests are resolved.

@jbfaden
Copy link
Member Author

jbfaden commented Apr 18, 2023

James says: "I pulled the latest and while it did better for ~1.5 decades, the labels disappeared on my color bar. Specifically, I started out with the full default range for the plot, which was about 4 decades. I then zoomed in to about 1.5-2 decades. Then I clicked about ¾ of the way up and dragged down past the bottom of the color bar in the hopes that it would accept the new upper point (where I clicked) and zoom out on the lower end. That’s when the labels just altogether disappeared."

It sounds like a 0 is getting into the minor ticks.

@jbfaden
Copy link
Member Author

jbfaden commented Apr 18, 2023

Also I need to add "1" in addition to 2,4,6,8 ticks.

@jbfaden
Copy link
Member Author

jbfaden commented Apr 22, 2023

James and I weren't able to reproduce the problem he saw, where presumably 0 was getting into the ticks. Also I think 0 would probably not cause problems, since each of the tick values is transformed, and 0 must be handled. He's keeping an eye out for this.

"1", or actually "10" is added when counting off linear ticks with 2,4,6,8,10. Before it would only count off 2,4,6,8 so the major boundary didn't have a tick.

@jbfaden
Copy link
Member Author

jbfaden commented Apr 22, 2023

I've verified that an x-axis with log ticks is working fine, too. See https://github.com/autoplot/dev/blob/master/demos/2023/20230422/LogXaxisIssue51.jy

@jbfaden jbfaden closed this as completed Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant