-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New code for log-y-axis when 1.5 cycles is visible doesn't work well with log-x-axis #51
Comments
This is looking better now, and considers the number of ticks to target. |
of ticks that can fit in the space. Back off change before studying jenkins.
I'm backing this out until next week, since this needs to be done early in the day because so many Autoplot tests fail. |
again so we can study Autoplot jenkins tests.
new 1.5-cycle log ticks code introduced again and Autoplot jenkins tests are resolved. |
James says: "I pulled the latest and while it did better for ~1.5 decades, the labels disappeared on my color bar. Specifically, I started out with the full default range for the plot, which was about 4 decades. I then zoomed in to about 1.5-2 decades. Then I clicked about ¾ of the way up and dragged down past the bottom of the color bar in the hopes that it would accept the new upper point (where I clicked) and zoom out on the lower end. That’s when the labels just altogether disappeared." It sounds like a 0 is getting into the minor ticks. |
Also I need to add "1" in addition to 2,4,6,8 ticks. |
James and I weren't able to reproduce the problem he saw, where presumably 0 was getting into the ticks. Also I think 0 would probably not cause problems, since each of the tick values is transformed, and 0 must be handled. He's keeping an eye out for this. "1", or actually "10" is added when counting off linear ticks with 2,4,6,8,10. Before it would only count off 2,4,6,8 so the major boundary didn't have a tick. |
I've verified that an x-axis with log ticks is working fine, too. See https://github.com/autoplot/dev/blob/master/demos/2023/20230422/LogXaxisIssue51.jy |
There's new code to calculate labels for the y axis when it is log and has a small number of cycles (0.5 to 5 for example), and it messes up when the x axis is log, at least when they are connected by a DataRange object.
Also the new code doesn't consider the height when calculating ticks. This should also be resolved.
The text was updated successfully, but these errors were encountered: