Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: npm ci and npm run build #99

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

Saibamen
Copy link
Contributor

Run npm ci and npm run build commands on every push

Running workflow: https://github.com/Saibamen/svelte-table/actions/runs/2735321347

@dasDaniel
Copy link
Owner

Until some test are added, the github action is not going to offer much beyond a smoke test.
Should probably include an audit as-well

@Saibamen
Copy link
Contributor Author

IMO even small GH actions can bring some benefits.
For example here, we can check if code from PRs can be build and all NPM dependencies can be installed - without downloading code from PR and compiling on local computer

@dasDaniel dasDaniel merged commit 739cff4 into dasDaniel:develop Jul 26, 2022
@Saibamen Saibamen deleted the github_actions branch July 27, 2022 10:39
@Saibamen Saibamen mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants