Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DSP-1178) Add Impressum, edit landing page #182

Merged
merged 3 commits into from
Dec 17, 2020
Merged

(DSP-1178) Add Impressum, edit landing page #182

merged 3 commits into from
Dec 17, 2020

Conversation

SepidehAlassi
Copy link
Collaborator

resolves DSP-1178

  • adds Impressum to the landing page
  • edit the content of the landing page (e.g remove beta release stuff)
  • edit contact info

gautschr
gautschr approved these changes Dec 17, 2020
View reviewed changes
Copy link

@gautschr gautschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

flavens
flavens reviewed Dec 17, 2020
View reviewed changes
Copy link
Contributor

@flavens flavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, just. a few comments.
N.B. In the contact page, github should be written "GitHub"

src/app/contact/contact.component.html Outdated
<a href="mailto:martin.mattmueller@unibas.ch">martin.mattmueller@unibas.ch</a>
<br/>

Bernoulli Euler Center (<a href="https://bez.unibas.ch/en/">BEZ</a>), University of Basel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would open this webiste on a new tab, using target="_blank"

src/app/contact/contact.component.html Outdated

Digital Humanities Lab, University of Basel
Data and Service Center for the Humanities (<a href="https://dasch.swiss/">DaSCH</a>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: I would open this website on a new tab, using target="_blank"

@SepidehAlassi
Copy link
Collaborator Author

@flavens and @gautschr Thanks to both of you for your quick reviews.

@SepidehAlassi SepidehAlassi merged commit c71d097 into develop Dec 17, 2020
@SepidehAlassi SepidehAlassi deleted the wip/DSP-1178-addImpressum branch December 17, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavens flavens flavens left review comments

@gautschr gautschr gautschr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SepidehAlassi @flavens @gautschr