-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up for new release (DSP-1338) #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some remarks and I could not test the UI because I do not have the data
and the tests failed...
@@ -91,7 +91,7 @@ <h4 class="subheading-2"> | |||
</div> | |||
|
|||
<div *ngIf="props?.sysnum[0]"> | |||
<h4 class="subheading-2">{{props?.sysnum[0].propertyLabel}}</h4> | |||
<h4 class="subheading-2">Metadata in HAN catalog</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say: Metadata in the HAN catalog
|
||
} | ||
|
||
mapToComponent(referredResourceType: string, referredResourceIri: string): void { | ||
this._beolService.routeByResourceType(referredResourceType, referredResourceIri); | ||
mapToComponent(referredResourceType: string, referredResourceIri: string, refferedResource: ReadResource): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a typo: referred and not reffered - written referred in the beol service
resolves DSP-1338