feat: expose DELETE /admin/projects as ZIO HTTP route (DEV-1587) #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story DEV-1587 · DSP-API: Expose admin/projects routes with ZIO HTTP |
Codecov ReportBase: 86.48% // Head: 86.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
==========================================
+ Coverage 86.48% 86.64% +0.15%
==========================================
Files 271 278 +7
Lines 28336 28404 +68
==========================================
+ Hits 24506 24610 +104
+ Misses 3830 3794 -36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 7 commits
January 16, 2023 14:53
seakayone
reviewed
Jan 17, 2023
| @@ -192,4 +193,22 @@ object ProjectsRouteZSpec extends ZIOSpecDefault { | |||
| } yield assertTrue(body.contains(shortname)) | |||
| } | |||
| ) | |||
|
|
|||
| val deleteProjectSpec = | |||
There was a problem hiding this comment.
I guess you will have to add this test to a suite otherwise it will be ignored.
seakayone
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-1587
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?