Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ziofy ValuesResponderV1 (DEV-1751) #2496

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Mar 1, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-1751

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@seakayone seakayone changed the title ziofy ValuesResponderV1 refactor: ziofy ValuesResponderV1 (DEV-1751) Mar 1, 2023
@linear
Copy link

linear bot commented Mar 1, 2023

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 0.52% and project coverage change: -76.52 ⚠️

Comparison is base (e2dcd43) 86.67% compared to head (acf3722) 10.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2496       +/-   ##
===========================================
- Coverage   86.67%   10.16%   -76.52%     
===========================================
  Files         287      287               
  Lines       29669    29665        -4     
===========================================
- Hits        25716     3015    -22701     
- Misses       3953    26650    +22697     
Impacted Files Coverage Δ
...la/org/knora/webapi/core/actors/RoutingActor.scala 0.00% <ø> (-96.16%) ⬇️
...esponder/standoffmessages/StandoffMessagesV1.scala 0.00% <ø> (-75.00%) ⬇️
...s/v1/responder/valuemessages/ValueMessagesV1.scala 0.00% <ø> (-69.40%) ⬇️
...ora/webapi/responders/v1/StandoffResponderV1.scala 0.00% <0.00%> (-36.67%) ⬇️
...knora/webapi/responders/v1/ValuesResponderV1.scala 0.00% <0.00%> (-93.10%) ⬇️
...c/main/scala/org/knora/webapi/util/ZioHelper.scala 100.00% <100.00%> (ø)
...bapi/src/main/scala/org/knora/webapi/package.scala 0.00% <0.00%> (-100.00%) ⬇️
...i/src/main/scala/org/knora/webapi/core/State.scala 0.00% <0.00%> (-100.00%) ⬇️
...rc/main/scala/org/knora/webapi/LanguageCodes.scala 0.00% <0.00%> (-100.00%) ⬇️
...c/main/scala/org/knora/webapi/core/AppRouter.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 207 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone marked this pull request as ready for review March 1, 2023 12:36
@seakayone seakayone requested review from mpro7, irinaschubert and BalduinLandolt and removed request for mpro7 March 1, 2023 12:36
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a cosmetic remark, feel free to ignore it

@seakayone seakayone force-pushed the wip/ziofy-ValuesResponderV1 branch from 1566b08 to 3366b21 Compare March 2, 2023 13:10
@seakayone seakayone merged commit 9b68e89 into main Mar 2, 2023
@seakayone seakayone deleted the wip/ziofy-ValuesResponderV1 branch March 2, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants