-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ziofy ValuesResponderV1 (DEV-1751) #2496
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2496 +/- ##
===========================================
- Coverage 86.67% 10.16% -76.52%
===========================================
Files 287 287
Lines 29669 29665 -4
===========================================
- Hits 25716 3015 -22701
- Misses 3953 26650 +22697
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
webapi/src/main/scala/org/knora/webapi/responders/v1/ValuesResponderV1.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a cosmetic remark, feel free to ignore it
webapi/src/main/scala/org/knora/webapi/responders/v1/ValuesResponderV1.scala
Outdated
Show resolved
Hide resolved
1566b08
to
3366b21
Compare
Pull Request Checklist
Task Description/Number
Issue Number: DEV-1751
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?