Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ziofy ResourceTypesRouteV1 (DEV-2034) #2578

Merged
merged 10 commits into from
Apr 12, 2023

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Apr 11, 2023

Pull Request Checklist

Task Description/Number

Issue Number: DEV-2034

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@linear
Copy link

linear bot commented Apr 11, 2023

@seakayone seakayone self-assigned this Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 0.97% and project coverage change: -69.05 ⚠️

Comparison is base (0612b9a) 86.94% compared to head (674dd70) 17.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2578       +/-   ##
===========================================
- Coverage   86.94%   17.90%   -69.05%     
===========================================
  Files         267      267               
  Lines       28720    28705       -15     
===========================================
- Hits        24972     5140    -19832     
- Misses       3748    23565    +19817     
Impacted Files Coverage Δ
...n/scala/org/knora/webapi/routing/RouteUtilV1.scala 0.00% <0.00%> (-87.15%) ⬇️
...la/org/knora/webapi/routing/v1/AssetsRouteV1.scala 0.00% <ø> (-4.77%) ⬇️
...nora/webapi/routing/v1/AuthenticationRouteV1.scala 0.00% <ø> (-84.22%) ⬇️
...cala/org/knora/webapi/routing/v1/CkanRouteV1.scala 0.00% <ø> (-11.12%) ⬇️
...ala/org/knora/webapi/routing/v1/ListsRouteV1.scala 0.00% <0.00%> (-16.67%) ⬇️
.../org/knora/webapi/routing/v1/ProjectsRouteV1.scala 0.00% <0.00%> (-100.00%) ⬇️
...knora/webapi/routing/v1/ResourceTypesRouteV1.scala 0.00% <0.00%> (-9.84%) ⬇️
.../org/knora/webapi/routing/v1/StandoffRouteV1.scala 0.00% <0.00%> (-73.69%) ⬇️
...ain/scala/org/knora/webapi/routing/ApiRoutes.scala 21.95% <12.50%> (-78.05%) ⬇️

... and 181 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seakayone seakayone marked this pull request as ready for review April 12, 2023 06:53
@seakayone seakayone enabled auto-merge (squash) April 12, 2023 13:29
@seakayone seakayone merged commit 31a8206 into main Apr 12, 2023
@seakayone seakayone deleted the wip/ziofy-ResourceTypesRouteV1 branch April 12, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants