Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): Run integration tests on actuated again #3027

Merged
merged 2 commits into from Feb 6, 2024

Conversation

BalduinLandolt
Copy link
Collaborator

@BalduinLandolt BalduinLandolt commented Feb 6, 2024

Pull Request Checklist

Task Description/Number

Reduces the duration of our integration test runs from ~23min to ~18min, which is not a huge difference, but still an improvement, I feel.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@BalduinLandolt BalduinLandolt self-assigned this Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eac5751) 11.74% compared to head (ec37ecb) 88.51%.
Report is 50 commits behind head on main.

❗ Current head ec37ecb differs from pull request most recent head 7fc7b75. Consider uploading reports for the commit 7fc7b75 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3027       +/-   ##
===========================================
+ Coverage   11.74%   88.51%   +76.77%     
===========================================
  Files         246      258       +12     
  Lines       22907    22846       -61     
===========================================
+ Hits         2690    20223    +17533     
+ Misses      20217     2623    -17594     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review February 6, 2024 12:44
Copy link
Collaborator

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :) It looks like 3-5 minutes faster. It only makes sense to apply actuated for the longest job we have, which are integration tests, right?

@BalduinLandolt BalduinLandolt enabled auto-merge (squash) February 6, 2024 15:00
@BalduinLandolt BalduinLandolt merged commit ca8319c into main Feb 6, 2024
11 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/bring-back-actuated branch February 6, 2024 15:06
@alexellis
Copy link
Contributor

Hi 👋

If you use specific sizes here, it may run better. You're on one of the fastest machines available, so you may want to look over what we have written up on caching?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants