chore: Use explicit label for actuated #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "actuated" bare label has been deprecated. We've reached out several times to have this patched for Dasch Swiss, so I'm sending a PR to make it a bit easier. The value for the vCPU and RAM matches the default. Feel free to amend as necessary in future PRs. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
requested review from
BalduinLandolt,
mpro7,
seakayone and
siers
as code owners
|
@subotic please could you take a look? I think this may be the remaining repository using the deprecated label format for actuated. |
BalduinLandolt
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Looks good to me. @subotic can be merged, right?
Thanks @alexellis for submitting the PR!
BalduinLandolt
changed the title
|
Hi @BalduinLandolt yes it should be merged, this newer label is being used elsewhere already in the organisation. For instance: https://github.com/dasch-swiss/dsp-meta/blob/9e4f2b9ba0ee5e17525e2d386a2fc34e7194456c/.github/workflows/main.yml#L14 Alex |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use explicit label for actuated
The "actuated" bare label has been deprecated. We've reached out several times to have this patched for Dasch Swiss, so I'm sending a PR to make it a bit easier.
The value for the vCPU and RAM matches the default. Feel free to amend as necessary in future PRs.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?
Does this PR change client-test-data?