Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure xsd:decimal is used for interval values #1400

Merged
merged 2 commits into from Aug 26, 2019
Merged

fix: Ensure xsd:decimal is used for interval values #1400

merged 2 commits into from Aug 26, 2019

Conversation

benjamingeer
Copy link

Fixes #1399.

@benjamingeer benjamingeer self-assigned this Aug 26, 2019
@benjamingeer benjamingeer mentioned this pull request Aug 26, 2019
Closed
tobiasschweizer
tobiasschweizer suggested changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test in ResourcesRouteV2E2ESpec for http://rdfh.ch/0001/H6gBWUuJSuuO-CilHV8kQw?

@benjamingeer benjamingeer changed the title test: Fix interval value in anything test data fix: Ensure xsd:decimal is used for interval values Aug 26, 2019
@benjamingeer
Copy link
Author

Could you please add a test in ResourcesRouteV2E2ESpec for http://rdfh.ch/0001/H6gBWUuJSuuO-CilHV8kQw?

Done in 67414e9. I also changed the templates that create values, and changed the test that creates an interval value.

tobiasschweizer
tobiasschweizer approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving this so quickly!

I actually just wanted to generate some test data for the client lib that would be easy to regenerate automatically ...

@benjamingeer
Copy link
Author

I'm glad we could fix it before we actually support audio and video files. :)

@tobiasschweizer
Copy link
Contributor

I'm glad we could fix it before we actually support audio and video files. :)

I guess you could have corrected the date with the update-repo script. But I agree, it is better this way!

@benjamingeer benjamingeer merged commit c62cc37 into develop Aug 26, 2019
@benjamingeer benjamingeer deleted the fix/1399-test-data branch August 26, 2019 11:35
@benjamingeer benjamingeer mentioned this pull request Aug 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasschweizer tobiasschweizer tobiasschweizer approved these changes

Assignees

@benjamingeer benjamingeer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with interval value
2 participants
@benjamingeer @tobiasschweizer