fix(api-v2): Fix incorrect serialisation of lastModificationDate #1442
Conversation
|
@benjamingeer I will fix the anything ontology's last mod. date on this branch |
|
dasch-swiss/dsp-js-lib#58 fixes the parsing of the lastModficationDate for knora-api-js-lib. |
# Conflicts: # webapi/src/test/resources/test-data/ontologyR2RV2/anythingOntologyWithValueObjects.rdf
# Conflicts: # webapi/src/test/resources/test-data/ontologyR2RV2/anythingOntologyWithValueObjects.rdf
|
@tobiasschweizer Is this OK to merge? Lukas said we don't need to wait for knora-py. |
|
I think it would be good to merge #1577 first. With that PR, the tests will only pass if dasch-swiss/dsp-js-lib#58 is implemented correctly. This is because #1577 automatically generates client code and test data from the Knora client api route, integrates it into knora-api-js-lib and runs the unit tests with the generated code and test data. |
|
In this case, however, this would mean that the correct branch of knora-api-js-lib has to be used with this PR. |
I don't understand. This PR only affects API v2, so it doesn't affect any generated code. |
It is just to make sure that knora-api-js-lib is actually in sync with knora-api |
OK. Anyway it looks like one of the tests is still broken, I'll look at it tomorrow. |
|
Test wasn't broken, I reran it on GitHub and it worked this time. |
|
Will look at this tomorrow too. I would be glad to get rid of these open PRs. Open for too long ... |
That's why I want to generate as much client code as possible. |
|
Ok, I am generating the client code from this PR and will integrate it into the tracking PR dasch-swiss/dsp-js-lib#58 to see if anything is missing. |
|
@benjamingeer @subotic This PR will necessitate a new published version https://github.com/dasch-swiss/knora-api-js-lib to be used with the release of Knora this PR is integrated into. |
There was a problem hiding this comment.
Ok, looks good! Pleas review dasch-swiss/dsp-js-lib#58 and then this PR is good to go.
|
@tobiasschweizer Thanks for the review! |
This fixes the serialisation of
knora-api:lastModificationDatein ontology requests/responses.Clients that use the ontology API will need to update.
Fixes #1439.
Needs dasch-swiss/knora-ui#324.
Needs dasch-swiss/dsp-tools#11.
Needs dasch-swiss/dsp-js-lib#47.