Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add makefile based tasks #1450

Closed
wants to merge 10 commits into from
Closed

Conversation

subotic
Copy link
Collaborator

@subotic subotic commented Sep 25, 2019

  • build and publish docs

  • build and publish Knora specific Docker containers

  • run complete knora-stack locally

  • Still missing. Will be added in future PRs:

    • start only db, redis, sipi - usefull for local dev on api
    • start db, redis and locally build sipi
    • start stack for IT-tests (will be added in PR feat: Upgrade sipi to 2.0.1 #1459)

@subotic subotic self-assigned this Sep 26, 2019
@subotic subotic added this to the 2019-10 milestone Sep 26, 2019
@subotic subotic added chore maintenance and build tasks ops and removed chore maintenance and build tasks labels Sep 26, 2019
@benjamingeer
Copy link

Thanks, will look at this tomorrow.

@subotic
Copy link
Collaborator Author

subotic commented Oct 3, 2019

Great, thanks. I will work on it further in PR #1459. There I need to fix the IT-Tests and for this I need the IT-version of the Knora-Stack running.

Copy link

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a little problem with variables in the Makefile:

$ make all
docker run --rm -it -v WD:/knora -v OME/.ivy2:/root/.ivy2 daschswiss/sbt-paradox /bin/sh -c "cd /knora && sbt docs/makeSite"
docker: Error response from daemon: create OME/.ivy2: "OME/.ivy2" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
See 'docker run --help'.
make: *** [build-docs] Error 125

@subotic
Copy link
Collaborator Author

subotic commented Oct 4, 2019

Sorry about that. It should work now. In the meantime, I've expanded the feature set in PR #1459.

@benjamingeer
Copy link

make knora-stack-up stops with this error:

Screenshot 2019-10-08 at 09 36 21

@benjamingeer
Copy link

And if I choose y, it fails:

Screenshot 2019-10-08 at 09 38 34

@subotic
Copy link
Collaborator Author

subotic commented Oct 11, 2019

I'm going to close this branch without merging. In PR #1459 I've added more things, which required changes to the tests.

@subotic subotic closed this Oct 11, 2019
@subotic subotic deleted the wip/1449-makefile-based-tasks branch October 11, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants