Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Try to fix build status badge again #1551

Merged
merged 4 commits into from Dec 10, 2019

Conversation

benjamingeer
Copy link

No description provided.

@benjamingeer benjamingeer self-assigned this Dec 6, 2019
@benjamingeer
Copy link
Author

@subotic This still doesn't work, but I can't figure out why.

@subotic
Copy link
Collaborator

subotic commented Dec 6, 2019

Maybe using Shield.io (https://shields.io/category/build) will work better?

Also, the default branch for knora-api is develop and according to the documentation should be used if no branch is specified.

@benjamingeer
Copy link
Author

After waiting a bit, the image URL seems to be working now. Shall we merge it like this?

@subotic subotic self-requested a review December 9, 2019 06:31
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-)

@benjamingeer
Copy link
Author

@subotic The GitHub CI build is failing, do you have any idea why we're getting this error?

Screenshot 2019-12-09 at 09 51 25

@subotic
Copy link
Collaborator

subotic commented Dec 9, 2019

@subotic The GitHub CI build is failing, do you have any idea why we're getting this error?

The error does not make sense. There is no reason why it should fail. Nevertheless, I've made a small change and let's see if it will work now.

@benjamingeer
Copy link
Author

@subotic Same error. Should we just disable GitHub CI completely? It's become impossible to merge anything.

@benjamingeer benjamingeer mentioned this pull request Dec 9, 2019
@subotic
Copy link
Collaborator

subotic commented Dec 10, 2019

good to go :-)

@benjamingeer
Copy link
Author

Thank you 🧙‍♂️!

@benjamingeer benjamingeer merged commit 4dad1d7 into develop Dec 10, 2019
@benjamingeer benjamingeer deleted the fix/ci-build-label-again branch December 10, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants